Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: Treat same scan point at 0 and 360 deg correctly #67

Merged
merged 1 commit into from
Feb 20, 2019
Merged

Conversation

alongd
Copy link
Member

@alongd alongd commented Feb 20, 2019

when identifying valleys in rotor scans

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #67 into master will decrease coverage by 29.56%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #67       +/-   ##
==========================================
- Coverage   32.81%   3.25%   -29.57%     
==========================================
  Files          19      18        -1     
  Lines        4339    3408      -931     
  Branches     1136     874      -262     
==========================================
- Hits         1424     111     -1313     
- Misses       2679    3293      +614     
+ Partials      236       4      -232
Impacted Files Coverage Δ
arc/ts/__init__.py 0% <0%> (-100%) ⬇️
arc/job/submit.py 0% <0%> (-100%) ⬇️
arc/job/__init__.py 0% <0%> (-100%) ⬇️
arc/job/inputs.py 0% <0%> (-100%) ⬇️
arc/__init__.py 20% <0%> (-80%) ⬇️
arc/ts/atst.py 0% <0%> (-77.15%) ⬇️
arc/parser.py 0% <0%> (-68.09%) ⬇️
arc/rmgdb.py 10.27% <0%> (-62.33%) ⬇️
arc/reaction.py 0% <0%> (-42.36%) ⬇️
arc/ts/run_autotst.py 0% <0%> (-34.38%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e01b76...9e9b608. Read the comment docs.

@codecov
Copy link

codecov bot commented Feb 20, 2019

Codecov Report

Merging #67 into master will decrease coverage by 0.02%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #67      +/-   ##
==========================================
- Coverage   32.81%   32.79%   -0.03%     
==========================================
  Files          19       19              
  Lines        4339     4342       +3     
  Branches     1136     1137       +1     
==========================================
  Hits         1424     1424              
  Misses       2679     2679              
- Partials      236      239       +3
Impacted Files Coverage Δ
arc/species.py 59.63% <40%> (-0.2%) ⬇️
arc/reaction.py 42.35% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6e01b76...6dafd2e. Read the comment docs.

when identifying valleys in rotor scans
@alongd alongd merged commit c046a22 into master Feb 20, 2019
@alongd alongd deleted the cycrotfix branch February 20, 2019 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant